xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
91 stars 21 forks source link

ENH: copy_to supports aio files #32

Closed ChengjieLi28 closed 1 year ago

ChengjieLi28 commented 1 year ago

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

Merging #32 (2b628f3) into main (5dd2fa7) will decrease coverage by 0.04%. The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   93.66%   93.63%   -0.04%     
==========================================
  Files          42       42              
  Lines        3332     3361      +29     
  Branches      668      672       +4     
==========================================
+ Hits         3121     3147      +26     
- Misses        140      141       +1     
- Partials       71       73       +2     
Flag Coverage Δ
unittests 93.48% <97.56%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/context.py 94.17% <97.05%> (+0.24%) :arrow_up:
python/xoscar/backends/pool.py 95.94% <100.00%> (+0.02%) :arrow_up:

... and 1 file with indirect coverage changes

ChengjieLi28 commented 1 year ago

Maybe we can use sendfile to optimize performance on the Linux platform and add an asv benchmark.

Sure. Here's an issue #34 . Will have another PR later.