xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
91 stars 21 forks source link

Revert "BUG: disable import cuda error when cpu only in a shared python env" #49

Closed ChengjieLi28 closed 1 year ago

ChengjieLi28 commented 1 year ago

Reverts xorbitsai/xoscar#47

Here' a big issue due to this PR: When the use's env has some problem (for example, python env has cupy and cudf, while the machine is a cpu machine), this pr will leads to some unexpected problems. Because in this case cudf is not None is True, but when user uses cudf.xxx, problems would happen.

Will fix this in another PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #49 (6f341db) into main (a7c94f7) will decrease coverage by 0.15%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   93.75%   93.60%   -0.15%     
==========================================
  Files          42       42              
  Lines        3361     3361              
  Branches      672      672              
==========================================
- Hits         3151     3146       -5     
- Misses        138      144       +6     
+ Partials       72       71       -1     
Flag Coverage Δ
unittests 93.45% <ø> (-0.15%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes