xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
89 stars 21 forks source link

ENH: Remove StatelessActor #69

Open codingl2k1 opened 1 year ago

codingl2k1 commented 1 year ago

What do these changes do?

The StatelessActor is ambiguity, remove it and use a class attribute __xoscar_lock_type__ instead.

Related issue number

Fixes https://github.com/xorbitsai/xoscar/issues/67

Check code requirements

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c7f3de4) 89.02% compared to head (7e68a37) 89.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ======================================= Coverage 89.02% 89.02% ======================================= Files 48 48 Lines 4010 4010 Branches 764 764 ======================================= Hits 3570 3570 Misses 355 355 Partials 85 85 ``` | [Flag](https://app.codecov.io/gh/xorbitsai/xoscar/pull/69/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xorbitsai/xoscar/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | `88.85% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.