xorbitsai / xoscar

Python actor framework for heterogeneous computing.
https://xoscar.dev
Apache License 2.0
89 stars 21 forks source link

ENH: stop using daemon=True for subpool #85

Closed qinxuye closed 6 months ago

qinxuye commented 6 months ago

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.52%. Comparing base (2a041ae) to head (5ba4fe0).

:exclamation: Current head 5ba4fe0 differs from pull request most recent head 1a58569. Consider uploading reports for the commit 1a58569 to get more accurate results

Files Patch % Lines
python/xoscar/backends/pool.py 95.83% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #85 +/- ## ========================================== - Coverage 89.12% 88.52% -0.61% ========================================== Files 48 47 -1 Lines 4010 3948 -62 Branches 764 757 -7 ========================================== - Hits 3574 3495 -79 - Misses 351 365 +14 - Partials 85 88 +3 ``` | [Flag](https://app.codecov.io/gh/xorbitsai/xoscar/pull/85/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xorbitsai/xoscar/pull/85/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai) | `88.44% <97.29%> (-0.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xorbitsai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.