xoreos / xoreos-tools

Tools to help the development of xoreos
https://xoreos.org/
GNU General Public License v3.0
66 stars 28 forks source link

XOREOSTEXT2TGA: Add TXI file export along with TGA output when available #78

Closed nadrino closed 2 years ago

nadrino commented 2 years ago

XOREOSTEXT2TGA: Add TXI file export along with TGA output when available

DrMcCoy commented 2 years ago

Hi, that's a good idea, thanks!

However, you're commit doesn't follow our Code Formatting Conventions and Commit Guidelines. Please read those links and/or observe how the code already in the repository is formatted and how the commit messages are usually styled.

The general "Developer Central" page on our wiki has some more resources: https://wiki.xoreos.org/index.php?title=Developer_Central

Feel free to fix your contribution, changing the commit and force-pushing onto your branch to update the pull request, thanks!

nadrino commented 2 years ago

Is it the oneliner for loop which does not follow your coding style?

DrMcCoy commented 2 years ago

Things that don't conform in the code:

Things that don't conform in the commit message

Also, doesn't outFile already include the .tga extension? The txi will then be written to "foo.tga.txi". Not sure if that's what should be done. There's a changeExtension() method in Common::FilePath you could use to change that.

nadrino commented 2 years ago

Thank you very much! I'll change that

nadrino commented 2 years ago

Ok, now the coding/commit message style should match. I also squashed the commits into a single one

DrMcCoy commented 2 years ago

Merged as 2e6081b0930bf9d223480d8b8c47b863959e1960, thanks! :)