Closed nadrino closed 2 years ago
Hi, that's a good idea, thanks!
However, you're commit doesn't follow our Code Formatting Conventions and Commit Guidelines. Please read those links and/or observe how the code already in the repository is formatted and how the commit messages are usually styled.
The general "Developer Central" page on our wiki has some more resources: https://wiki.xoreos.org/index.php?title=Developer_Central
Feel free to fix your contribution, changing the commit and force-pushing onto your branch to update the pull request, thanks!
Is it the oneliner for
loop which does not follow your coding style?
Things that don't conform in the code:
if
and for
, and the between the )
and {
;
Things that don't conform in the commit message
[xoreostex2tga]
should be XOREOSTEXT2TGA:
Also, doesn't outFile
already include the .tga extension? The txi will then be written to "foo.tga.txi". Not sure if that's what should be done. There's a changeExtension()
method in Common::FilePath
you could use to change that.
Thank you very much! I'll change that
Ok, now the coding/commit message style should match. I also squashed the commits into a single one
Merged as 2e6081b0930bf9d223480d8b8c47b863959e1960, thanks! :)
XOREOSTEXT2TGA: Add TXI file export along with TGA output when available