search

xorpaul / g10k

my r10k fork in Go
Apache License 2.0
125 stars 50 forks source link

Add check in puppetfile if brach is set to :control_branch #124

Closed EggieCode closed 5 years ago

EggieCode commented 5 years ago

Hey,

We are used r10k deploying an environment with a use of control_branch. When you set the a specific environment it uses the environment brach if it exists else it fetches the default specified in Puppetfile.

When I use g10k with a config parameter it set the branch name with :control_branch filled in and it has more priority then tree attribute, when it clones the git repo it uses the branch control_branch instead of set environment branch.

To solve this I have added a extra parameter to the GitModule struct for a control_branch.

Greetz, Egbert

xorpaul commented 5 years ago

Please check out https://github.com/xorpaul/g10k/releases/tag/v0.5.9 or https://github.com/xorpaul/g10k/releases/tag/v0.6.0 if your issue with :control_branch is fixed.

EggieCode commented 5 years ago

Thanks you. That resolved the issue!