search

xorpaul / g10k

my r10k fork in Go
Apache License 2.0
125 stars 50 forks source link

Really respect `maxworker` parameter during git clone/remote update, close #140 #141

Closed maxenced closed 5 years ago

maxenced commented 5 years ago

It seems that since it has been implemented, maxworker does not work correctly. The main reason is that the done channel is filled outside of the go loop which spawn the func : https://github.com/xorpaul/g10k/blob/master/git.go#L88

Moving it to the end of the goroutine makes maxworker work correctly.