xorpaul / g10k

my r10k fork in Go
Apache License 2.0
125 stars 50 forks source link

forge code does not accept http 200 code without reason #219

Closed juliantaylor closed 7 months ago

juliantaylor commented 7 months ago

the core requires the code and the reason

if strings.TrimSpace(resp.Status) == "200 OK" {

https://github.com/xorpaul/g10k/blob/master/forge.go#L203 and a couple more places

in the http 1 spec the reason can be empty https://www.rfc-editor.org/rfc/rfc2616#section-6.1

so g10k will fail with

Unexpected response code 200