search

xorpaul / g10k

my r10k fork in Go
Apache License 2.0
125 stars 50 forks source link

-version doesn't show correct version #79

Closed baurmatt closed 6 years ago

baurmatt commented 6 years ago

I've just discovered that (at least for the last 3 releases) the -version parameter outputs the wrong version number:

mbaur@mbaur-g10k:~/test$ wget https://github.com/xorpaul/g10k/releases/download/v0.3.12/g10k-linux-amd64.zip
--2017-11-07 14:58:06--  https://github.com/xorpaul/g10k/releases/download/v0.3.12/g10k-linux-amd64.zip
Resolving github.com (github.com)... 192.30.253.112, 192.30.253.113
Connecting to github.com (github.com)|192.30.253.112|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/39644433/607f6d42-8f39-11e7-8c70-f842e8cb830a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20171107%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20171107T135806Z&X-Amz-Expires=300&X-Amz-Signature=d2de63fd80cf53bb26227c238916a14f49efcfeba97749696905bb92263b771d&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dg10k-linux-amd64.zip&response-content-type=application%2Foctet-stream [following]
--2017-11-07 14:58:06--  https://github-production-release-asset-2e65be.s3.amazonaws.com/39644433/607f6d42-8f39-11e7-8c70-f842e8cb830a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20171107%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20171107T135806Z&X-Amz-Expires=300&X-Amz-Signature=d2de63fd80cf53bb26227c238916a14f49efcfeba97749696905bb92263b771d&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dg10k-linux-amd64.zip&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)... 52.216.131.187
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (github-production-release-asset-2e65be.s3.amazonaws.com)|52.216.131.187|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2407015 (2.3M) [application/octet-stream]
Saving to: ‘g10k-linux-amd64.zip’

g10k-linux-amd64.zip                          100%[==============================================================================================>]   2.29M  1.62MB/s    in 1.4s

2017-11-07 14:58:08 (1.62 MB/s) - ‘g10k-linux-amd64.zip’ saved [2407015/2407015]

mbaur@mbaur-g10k:~/test$ unzip g10k-linux-amd64.zip
Archive:  g10k-linux-amd64.zip
  inflating: g10k
mbaur@mbaur-g10k:~/test$ ./g10k -version
g10k Version 1.0 Build time: 2017-09-01_15:16:52 UTC

Can this please the synced to the tag version? Thanks! :)

xorpaul commented 6 years ago

Fixed https://github.com/xorpaul/g10k/commit/0d07d8048ba141163b641b77fd02e48b87cfc88b