search

xorpd / fcatalog_server

Functions Catalog
GNU General Public License v3.0
28 stars 14 forks source link

Bug fix #2

Closed jimmy-sonny closed 5 years ago

jimmy-sonny commented 5 years ago

Missing return value.

xorpd commented 5 years ago

@jimmy-sonny : Thank you for your contribution! I have to admit I don't understand something. Indeed there seems to be a missing return statement. How is it possible that the code worked so far? What led you to finding this bug?

jimmy-sonny commented 5 years ago

Hi! I am doing some research in the field of the function similarity, and I found your project very interesting. I've also added your catalog1 library as one of the similarity engine of FIRST (https://first.talosintelligence.com/, https://github.com/vrtadmin/FIRST-server).

While I was implementing it, I found that the python implementation was returning different values than the C one, and I found the missing return value.

I did some tests, and I found out your code is really working correctly on Linux, but I was compiling it on Mac and I got a different behaviour.

xorpd commented 5 years ago

@jimmy-sonny : Very cool! I have never heard of FIRST. I should try it out some time. Do you support the latest IDA7? The latest upgrades pretty much broke fcatalog, I still have some fixes to do.