xorus / EngageTimer

Stopwatch / Countdown plugin for Dalamud
GNU Affero General Public License v3.0
16 stars 6 forks source link

Can not enable decimals without enabling big countdown #44

Closed BoredDan closed 1 year ago

BoredDan commented 1 year ago

Right now Enable big countdown acts as the Enable button for all countdown drawing features. This means it's not possible to simply enable the decimals/accurate countdown or change the number style without adding numbers before 5. Would be beneficial to allow us to enable other feature without requiring the full countdown to be shown. Even better would be to add a custom point to start displaying the countdown timer. This would allow for players to set up the timer based on what's useful for their classes pre-pull.

xorus commented 1 year ago

If I understand correctly, you would just want to show the big countdown only when X seconds are left.

Tell me if this scenario would be what you are describing, imagining I add this setting, and you set it to "7" : "Hide countdown above [ 7 ] seconds"

Did I understand you correctly ?

BoredDan commented 1 year ago

Essentially yes. I'd personally be fine with just the option for matching the default in game behaviour of only showing at 5s as that would allow me to replace the default numbers with the precise countdown and my preferred number style. But would make sense to me that if setting that up to just make the drawing start point fully custom.

Also realized I said numbers before 10 instead of 5 in the original post.

xorus commented 1 year ago

Yeah I got a bit confused. I will be implementing that then !

I'll definitely try to do it as soon as possible, but as a warning, I got very burnt out from the game recently so I can't promise when I will be able to do it ^^".

xorus commented 1 year ago

@BoredDan done! Can you confirm this behaviour is what you expect ?

https://user-images.githubusercontent.com/2473314/216443112-0cbb1a81-bdc5-44c1-aabf-e88978e3772c.mp4

Testing repository should be updated with this feature if you want to test it out before I publish it officially.