xosadmin / c5proj

“歡迎來到冒險家協會!Welcome to the Adventurers Guild! “
GNU General Public License v3.0
0 stars 0 forks source link

Centralize code for common code. #51

Closed Phyo09 closed 4 months ago

Phyo09 commented 4 months ago

We can make navigation bar centralize, meaning no need to repeat navigation html code for every pages. we can use external html embedded within the html pages (e.g., Jinja2)

Pro: When we make changes, no longer need to update the changes on every html instead do at base.html for common code or duplicated code.

Phyo09 commented 4 months ago

image

Below templates are yet to be completed.

Done

xosadmin commented 4 months ago

There are 2 navigations, depends on user login state. Also, we need to adopt "active" class on specific pages, based on Bootstrap. It is hard to make it centralise.

Phyo09 commented 4 months ago

There are 2 navigation based on user logged in or not, its centralized, Check again.

xosadmin commented 4 months ago

Done