xoseperez
commented
6 years ago I have started working on it on the "fastled" branch. New LIGHT_PROVIDER_FASTLED. At the moment only basic functionality using existing color objects. It turns on/off and changes color with transitions just like any other light provider. Next steps:
- Using FastLED color objects for DIMMER and MY92XX providers too. I'm concerned about the size of the final image and we have to find a clever way to store other color channels (some have up to 5 channels: RGB plus cold and warm whites).
- Fix the UI widget
- Effects (all lights at once, should be compatible with other providers as well), maybe replacing current color transition too.
- Effects part 2 (for addressable pixels, only using FastLED provider).
cnf
tarbax
samtap
mcspr
Originally reported by: Soif (Bitbucket: soif, GitHub: soif)
First, thank your for merging, and cleaning my IR/Effect PR (31).
I saw that you've implemented it really cleaner , but that you also removed the effects part, and my efforts to implement internal HSV color management using the Fastled library.
Removing my internal HSV management leaded to : (v1.10.2B)
The current web HSV palette has UI bugs.
Ie : Set color to any color other than red, let's say blue, now set the second (or third) fader to 0, then back to 255--> you reset to Red
This might be due to the :
var value = $(this).wheelColorPicker('getValue', 'css');vs my
var color = $(this).wheelColorPicker('getColor');and/or due to the internal RGB/HSV conversion not done perfectly.
--> My implementation did NOT have this problem :-p
Brightess (3rd fader in HSV mode, or bottom slider in RGB mode) is near useless!
Because the curse is brutally logarithmic.
--> My brightness implementation did NOT have this problem, and was gently linear :-p
==> I was using the FastLed library for that exact reason
Her color management of RGB Led strips is absolutely CLEVER and well designed.
IMHO, this is as important as her other feature which is : easily and fastly handling addressable led strip (whatever the Chipset type).
To learn more about her clever color implementation, you should specially read :
1) So Might I suggest to internally (re)-implement Fastled HSV color objects, and just translate to RGB for additional MQTT or API accesses.
-> this would add/restore :
2) Implementing Effects
I don't know if you've removed my effect code part because:
But, I might re-implement it (using Fasted, of course, to get beautiful transitions, and allowing addressable light strip effect in the future) if you agree.
So if you mind, would you please just add some DEFINE / IFDEF comments in the code, to give me a clue on where to implement it cleanly, (so that you wont have to highly clean my code after my PR).
Some needed concepts / DEFINES would certainly include something like:
For size reason, we might also plan to implements some basic effects (ie 5 to 10) in the effects.ino file, while adding additionals /more complex ones as optional plugins to include, depending on DEFINEd options.
Best regards