search

xoseperez / espurna

Home automation firmware for ESP8266-based devices
http://tinkerman.cat
GNU General Public License v3.0
2.98k stars 635 forks source link

Espurna + Blynk server #559

Open artemicruz opened 6 years ago

artemicruz commented 6 years ago

It would be wonderful to add blynk server connection. add blynk libraries are open source the user only needs: server, port and tocken (online or private)

http://docs.blynk.cc/#hardware-set-ups-esp8266-standalone

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

thaeger71 commented 5 years ago

Is someone working on this this ? Otherwise I would start to work on it .... but just for case there is already something, I would offer my help.

xoseperez commented 5 years ago

There is no active development on this, at least not in the main repo.

thaeger71 commented 5 years ago

Hey guys,

I forked the master branch and implented Blynk support. How is the correct way to get it into the regular branch ? Do I have to make a pull request ?

mcspr commented 5 years ago

@thaeger71 hey. please rebase it on 'dev' and you can open up a pr -> https://github.com/xoseperez/espurna/wiki/PullRequests

edit and you can avoid adding gulp output

xoseperez commented 5 years ago

The code looks mostly OK. I have not tested it yet. But I would not enable Blynk by default unless someone points out a very good reason to do it.

thaeger71 commented 5 years ago

The only reason i can point out is, it's not usable for those using precompiled binaries....and this would mean it's not usable for the majority....

Xose Pérez notifications@github.com schrieb am Do., 4. Okt. 2018, 21:14:

The code looks mostly OK. I have not tested it yet. But I would not enable Blynk by default unless someone points out a very good reason to do it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xoseperez/espurna/issues/559#issuecomment-427136854, or mute the thread https://github.com/notifications/unsubscribe-auth/ARFCEII2-fG3OCGnkdoItRYcsHV2DuIkks5uhl4NgaJpZM4SDZRD .

bluexp1 commented 5 years ago

Isn't there any plan to release this feature?

thaeger71 commented 5 years ago

It's a good question, I mean Max made also some effort to optimze things, now everthing seems to work, but so far I know there is no feedback from Xose on this so far ....

mcspr commented 5 years ago

Yep. #1230 PR is still pending (+ maybe needs another thought about wiring more things... and how that wiring is happening) I have not used it very much though.

thaeger71 commented 5 years ago

I marked everything pending as solved regarding #1230 is there something I have to in addition from my side ?

xoseperez commented 5 years ago

I'm going to release 1.13.4 first and then merge the code into dev.