search

xoseperez / espurna

Home automation firmware for ESP8266-based devices
http://tinkerman.cat
GNU General Public License v3.0
2.99k stars 637 forks source link

Blank page on iOS Safari #667

Closed sashimanu-san closed 6 years ago

sashimanu-san commented 6 years ago

In stock Safari on an iPhone, the Espurna control page renders totally blank, making the device uncontrollable from that device.

User agent is Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0 Mobile/15D100 Safari/604.1

lobradov commented 6 years ago

I’m experiencing the same issue - will check it when I get time in day or two...

Chrome works fine though

//_ on phone

On Mar 13, 2018, at 08:33, sashimanu-san notifications@github.com wrote:

In stock Safari on an iPhone, the Espurna control page renders totally blank, making the device uncontrollable from that device.

User agent is Mozilla/5.0 (iPhone; CPU iPhone OS 11_2_6 like Mac OS X) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0 Mobile/15D100 Safari/604.1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

gn0st1c commented 6 years ago

probably because safari has strict rules when it comes to headers. content-type, length etc.

thebradleysanders commented 6 years ago

It seems to be an error with the authentication in Safari.

sashimanu-san commented 6 years ago

Can't agree.

The auth prompt is displayed and, if the credentials are correct, not displayed again.

xoseperez commented 6 years ago

It's probably an error in websocket auth. It might be weird but you can log in using a different browser and disable websocket authentication in the web UI, admin tab. The you should be able to use Safari again. Check d9cd999db9ac57a56a59fe927901b6a84f8710b2.

zerog2k commented 6 years ago

is there a way to disable WS Auth during fw build time, maybe macro or something? Is it adding this as compiler define? -DNOWSAUTH ?

xoseperez commented 6 years ago

Set WS_AUTHENTICATION to 0 in general.h.

TarjeiD commented 6 years ago

The compatibility with Safari broke with 694d70d where ESPAsyncWebServer was updated to #232b87a. Going back to using #313f337, will also fix the issue with Safari on both MacOS and iOS.

xoseperez commented 6 years ago

Going back to https://github.com/me-no-dev/ESPAsyncWebServer#313f337 means disabling WS authentication for all users. 694d70d was meant to enable them while allowing users having problems with Safari to disable it manually, either via a compile setting or in the web UI. Of course, you should use a different browser to log in the web UI and disable WS authentication, once done you can use Safari again.

zerog2k commented 6 years ago

Not so familiar with the wsauth option, but wondering if it would be possible to detect "problematic" browser user-agent to dynamically switch to different auth for the session? Is this something implemented in espurna, or in the ESPAsyncWebServer codebase?

xoseperez commented 6 years ago

Not in ESPurna, right now it's a manual setting. I don't know how such a feature could be implemented. User agent maybe?

TarjeiD commented 6 years ago

I like your focus on security. That's why I settled on ESPurna over ESPEasy and Sonoff-Tasmota. Why can't the authentication be performed using http before switching to WS?

chryss44 commented 6 years ago

Hi all, I have tried on Safari MacBook (Sierra) with Firmware v1.12.1 and work well. On 1.12.4 not work and blank page with this message on web dev console : "WebSocket connection to 'ws://192.168.44.65/ws' failed: Unexpected response code: 401 "

xoseperez commented 6 years ago

@chryss44 There was a change in 1.12.4 to recover ws auth for security reasons and add the option to disable it manually. Websocket communication in 1.12.1 is open.

@TarjeiD Yes, that was the original approach and I changed it when ESPAsyncWebServer recovered the ws auth method. I guess it was a bad move.

skyynet commented 6 years ago

I wanted to use an old iPod Touch (4. Gen) with iOS 6.1.6 to switch my Electrodragon WiFi relay board and also get a blank page in Safari. On my iPhone X with iOS 11.3.1 it works just fine. WS Auth is turned off.

xoseperez commented 6 years ago

Sorry, I hope you can understand it's impossible to support any possible hardware out there. I can only test the web interface on Chrome, FF for Linux and Android.

skyynet commented 6 years ago

Of course I see the point. I thought you might have experience with the behavior of older Mobile Safari versions which could workaround the issue. Since I just programmed a WebApp which calls the relay board via REST API it's not a problem for me.

0anton commented 6 years ago

Hi,

I am using ESPURNA 1.12.6 on Sonoff Pow switch. Web-Interface does not load (blank page) on both Safari and Chrome browsers on Iphone and Ipad. Authentication pop-up shows up and after entering the password, the black page is rendered. Switching off Web-Socket authentication (WS Auth) in the web-console DOES help.

iphone & ipad iOS 11.3

Kind regards, Anton

mcspr commented 6 years ago

@0anton dev branch started using different authentication method for websockets, can you try https://github.com/xoseperez/espurna/commit/dff81d6795c4b6647463645c2f484be578d10562 build?

xoseperez commented 6 years ago

@0anton @skyynet @chryss44 @TarjeiD @sashimanu-san Can you test dev branch?

0anton commented 6 years ago

Hi Xose,

I could test the dev branch if upgrade is possible over web form. Is it the case or I need a to attach a programmer?

Kind regards, Anton Golubev

On Mon, Jun 11, 2018 at 9:30 PM, Xose Pérez notifications@github.com wrote:

@0anton https://github.com/0anton @skyynet https://github.com/skyynet @chryss44 https://github.com/chryss44 @TarjeiD https://github.com/TarjeiD @sashimanu-san https://github.com/sashimanu-san Can you test dev branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xoseperez/espurna/issues/667#issuecomment-396359005, or mute the thread https://github.com/notifications/unsubscribe-auth/AQgg5FJk31XH27C42X3tmUNHiV05uyzWks5t7sU5gaJpZM4SoM9w .

xoseperez commented 6 years ago

Released with 1.13.0. Closing.

zerog2k commented 6 years ago

Working much better with 1.13.0 thanks @xoseperez One comment/feedback is that while I'm able to log into the web ui on IOS Safari, I get sent to the change password page. I try to change the password, and it doesn't seem to do anything. However, I tried to login on another device (ipad), and the password seems like it was changed. So something about the initial change password prompt. (In general, it would be nice to be able to defer the password change (like for 1 time, or 24 hours, etc), so I can at least login to the device, and join it to my wifi network, then switch over to my PC for full configuration, where I would be happy to change password (and can use password manager ;)

SirJMD commented 6 years ago

I just flashed my Sonoff RF bridge with 1.13.0, but I can't load the web gui from my computer using chrome. From my phone it works fine.

thebradleysanders commented 6 years ago

Do you get the Web Auth prompt in Chrome?

SirJMD commented 6 years ago

Nope, nothing. Blank page only.

On Mon, 9 Jul 2018, 23:04 Brad Sanders, notifications@github.com wrote:

Do you get the Web Auth prompt in Chrome?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xoseperez/espurna/issues/667#issuecomment-403619948, or mute the thread https://github.com/notifications/unsubscribe-auth/AJi43sPUHxbb83FXWLuW3Qp7TqKdHn6gks5uE8VjgaJpZM4SoM9w .