Stop after X time - Githubissues

dvine2000 commented 3 years ago

First of all great power monitor. I just starting to migrate my fibaro LUA scene's to HA with node red.

It's always hard to monitor these powers.

For my case the start works fine but the stopping is hard. My washing machine bumps to 0w with not on all programms the same amount so one time the monitors stops send the payload good and other times it won't stop and no payload is sending.

My suggestion for the stopping is a time setting added. So when you put in 5 min. it's waiting that 0W is there for 5 min. before putting the power monitor to stop

Running my Fibaro scene for 7 years with this waiting stop timer and never had problems.

xoseperez commented 3 years ago

Hi If you set the stop threshold to 0W and the "stop after" value to 5, assuming you are feeding the node values every minute, it will trigger the stop event after 5 minutes of 0W readings. If there is any non-0W reading during those 5 minutes the stop counter will be reset. You are explicitly asking the node to trigger the event only after 0W readings in a row.

dvine2000 commented 3 years ago

Maybe I didn't explain good enough what I meant and want.

Stop after: Number of messages with readings below the threshold to trigger a stop event. I want stop after: X time below the threshold to trigger a stop event

In my case when things ending washing machine bumps 10 to 20 times to 0W and goes up to like 50 wats before the program stops and it's stay's 0W even in the middle of the program it goes to 0W a few times. (sorry for the A+++ washing machine) Dryer bumps maybe like 30 times to 2.4W (from 2.4 to 40W) every time before it's ending and stays at 2.4W

So when set stop after 1 it's stopping the first time what you don't want and with 2 or more it never stops because of the reset

But I can't judge a stop message amount because this is not a default value on my washing machine or dryer. And because of the reset function the monitor wont stop.

So that's why I asked for a extra function in the power monitor with a stop timer instead or next to messages amount so you can choose witch one you want. But I can sure you a stop after X time if below threshold X watts will always works. This way it's much easier to set a value that will always work without a complete analyse of your power usage of the dryer

xoseperez commented 3 years ago

I understand you are not feeding the node with power readings from the washing machine at regular intervals, then. Am I right? That's why you need a timer instead?

dvine2000 commented 3 years ago

No I feed the power monitor with my dryer or washing machine. Start threshold on 100 start after 1

and for now I used stop threshold 0 stop after 1

I made a own trigger if below 3W for 5 Min then power down wall plug. Power gets to 0 first time and the power monitor is get his first and only needed stop command. after that I get a telegram message.

I tried several settings like stop threshold 3 with stop after 1 or 2 or even 5 or more but or the stop command comes to quickly or it doesn't stop.

here is my flow that is working at this moment.

xoseperez commented 3 years ago

I see you are feeding the power monitor node with the output of a server-state-changed node, which will probably only let a message change if the power value changes, right? If that's the case I understand why you need the timer.

TBH the node was first conceived to be fed with regular (even if repetitive) values (like 0W, 0W, 0W,... every minute).

Will add this as an enhancement. In the meantime I'd suggest you to try a different approach, like feeding the data directly from the power device if possible, or timing the messages every minute.

Thank you.

dvine2000 commented 3 years ago

I understand now why it won't work like you meant to. For me is the only way to do it with a polling state node I think and check it every minute. I will test this way later on this week.

It's not complete clear in the usage tekst of node-red. Maybe ad the usage tekst: node need to be fed with regular (even if repetitive) values (like 0W, 0W, 0W,... every minute). Like you said so it's more clear in the manual of you power monitor.

Thanks for your time and looking into this and also add the enhancement. Keep up the good work

cg089 commented 2 years ago

+1 for this request. I use power monitor to monitor my solar roof. I am planing to send myself a message after a day how many watts (and how much money) I produced during the day. However, during cloudy days the roof sometimes make 0W at daytimes and continues to produce afterwards. This results in 1 (which is good) to n messages daily depending the weather.

I was wishing for an option to "Stop" after lets say "1/2/n hours of 0W readings". This would result in the planned 1 message.

Another problem that could be solved with that: my washing machine uses 0W the last couple of minutes, then again cleaning for around 15 minutes. But only when I use certain programs (white clothes at 60C). Using a different program (colored clothes at 40C) it is finished after the first time 0W. Currently I can't use the plugin to fully monitor my washing machine. An option "Stop" after "20 minutes of 0W" would perfectly monitor.

GerdRuetten commented 2 years ago

+1 from me too. My washing machine and my dryer have during working several 0 W levels for seconds time. The 0 W polling reset the power monitor, so it start always with 0.

ostat commented 2 years ago

I have created PR #17 (and #15 to a lesser extent) to assist with this scenario.

In my exp the devices I'm using messages don't appear to come in equally timed. A reading might come in at 10s, 45s, 55s then 95s for example. In this scenario the count for the stop was not as reliable as I might have liked. Waiting for 20 received messages might be 5mins it might be 10mins.

The change allows the StartBefore and StopAfter to be seconds based instead or received message count based. Setting the StopAfter period to seconds, when a message arrives instead of checking a received message count since it went in to pre-stop, it checks number of seconds since entering pre-stop. The power-monitor uses the received messages to trigger update events, this is still the case. I didn't add an internal timer that could trigger the stop, it only checks the time when an event arrives.

For example if you set StopAfter to 60 and period to Seconds. The first zero value will set the pre-stop event and record the time. If a zero value is received at 55s then another one at 90s, the stop would occur at 90s.

This still leaves the issue of what if no message is received. For that we can use a Trigger node to send a stop message after 60s of the last message.

I would be interested if someone would like to try it out.

xoseperez / node-red-contrib-power-monitor

Stop after X time #10