xotahal / fastlane-plugin-semantic_release

Fully automated version management and generator of release notes

MIT License

213 stars 59 forks source link

Use lightweight tags in `analyze_commits` #33

Closed danielgomezrico closed 2 years ago

danielgomezrico commented 2 years ago

Hi

Current

The lane analyze_commits only analyze annotated tags. This line https://github.com/xotahal/fastlane-plugin-semantic_release/blob/master/lib/fastlane/plugin/semantic_release/actions/analyze_commits.rb#L23 will find only annotated tags.

The issue is that the GitHub UI for releases creates only lightweight tags (https://github.com/github/feedback/discussions/4924 and https://github.com/isaacs/github/issues/1916) so it is not possible to use Github to create the release tags for this.

Github UI:

Proposal

Read annotated and lightweight tags and just get the latest tag created Some docs here v2/Git-Basics-Tagging.

danielgomezrico commented 2 years ago

The current implementation already picks lightweight or annotated tags, so this makes no sense