search

xotahal / react-native-material-ui

Highly customizable material design components for React Native
MIT License
3.78k stars 610 forks source link

No Ripple effect after clicking on ListItem #311

Open xvonabur opened 6 years ago

xvonabur commented 6 years ago

There are some changes in ListItem which causes such behaviour:

  1. https://github.com/xotahal/react-native-material-ui/blob/master/src/ListItem/ListItem.react.js#L480
  2. https://github.com/xotahal/react-native-material-ui/blob/master/src/ListItem/ListItem.react.js#L500

They were introduced with this commit

After reverting commit above ripple effect is back.

My setup:

janziemba commented 6 years ago

I think this is the correct behavior, isn't it? It should not have the ripple effect if it's not pressable (missing onPress and onLongPress). If not so, please share a link to Material Design docs. Thank you.

xotahal commented 6 years ago

Why do we show visual feedback to user if there is no onPress?

xvonabur commented 6 years ago

@xotahal, @janziemba Why are you thinking about the case with no onPress? I didn't say about it. I do not see ripple effect, regarding passing function to onPress or not.

xvonabur commented 6 years ago

@xotahal, @janziemba Please, reopen it. I can provide a simple demo if needed.