Closed vv-monsalve closed 4 years ago
I have all this done in both Stencil & Inline except for the general check, which I'm doing this weekend.
thank you especially for catching error in the slope of the caron. I thought I'd fixed those already. same for wrong caron form with /L in Stencil.
the problems with Ldot and ldot.sc also needed fixing in Big Shoulders itself
I'm ok with the bar in hbar and dcroat jutting over the letter's bowl rather than being perfectly balanced since this typeface needs to pack so tightly. I did however find a problem where the Thin master had reversed paths in dcroat, so it created a crashing motion in some interpolated weights. that's fixed.
Big Shoulders also had issues with dcroat—the crossbar wasn't thick enough in either thin text or thin display. fixed.
my work on stencil is merged back in now. you'll see different kerning in the Polish, and some fixes where components and paths (in characters containing both) had fallen out of position. these fixes will also need to be made in Big Shoulders, that is my next task.
I'm glad to see the improvements. The only thing that concerns me right now is the PR still appears as open, as it hasn't been merged. Are you working on the latest files?
you'd made this fix, which failed to merge, and I didn't see. just did it.
https://github.com/xotypeco/big_shoulders/pull/24/commits/9cb6d231a312428c5156f010dabaf7a83d4a0b56
everything else is up to date. does this look ok on your end?
That commit was about one of the files to set up the CI cheks, that mentioned on the email. It failed at that moment, maybe because of a temporary internet connection issue. Big Shoulders production takes a few minutes given the extent of it, particularly in for Stencil and Inline variants. But you can see it is ok now.
This PR includes the latest source, production, and font files for the Inline family. The main fixes were:
After the merge, please review and adjust the following:
Kerning
Diacritics