search

xotypeco / big_shoulders

SIL Open Font License 1.1
69 stars 3 forks source link

New Fail reported after Fontbakery 0.7.35 version #35

Closed vv-monsalve closed 3 years ago

vv-monsalve commented 3 years ago

HI @xotypeco, Fontbakery has now a new version and there is a new Fail reported for the all the fonts (both VF + statics) in all the families:

🔥 FAIL: Ensure Stylistic Sets have description. * [com.google.fonts/check/stylisticset_description](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/stylisticset_description) 
--- Rationale ---
Stylistic sets must provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
* 🔥 **FAIL** The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
xotypeco commented 3 years ago

hi—.ss01 has more contemporary forms in three characters—a straight-legged R, an a with an open loop & an open-bowl g.

I don't know where this description happens, though. should you add this description, since you're pulling new masters?

Screen Shot 2021-05-13 at 8 18 03 AM
vv-monsalve commented 3 years ago

We are asking this Fail to be downgraded to a Warn as it is not something that actually broken in the font. Are you going to change anything in the sources for the Vietnamese or diagonal letters?

xotypeco commented 3 years ago

We are asking this Fail to be downgraded to a Warn as it is not something that actually broken in the font.

👍🏻

Are you going to change anything in the sources for the Vietnamese or diagonal letters?

already done! a few weeks ago. you should see slightly wider diagonals in Inline, and changed Vietnamese throughout.

vv-monsalve commented 3 years ago

already done!

Great! Didn't know if you wanted to change anything after the last images.