search

xou / elixlsx

An Elixir XLSX writer
MIT License
290 stars 112 forks source link

Make write_to and write_to_memory adhere to their typespecs #121

Open xpgdk opened 2 years ago

xpgdk commented 2 years ago

The typespecs state that {:ok, String.t()} is returned on success, but :zip.create will return {:ok, [char()]}.

xou commented 2 years ago

Thank you very much for this PR. Would it make sense to fix the typespec instead, so that users of the API are not broken by the next release?

xpgdk commented 2 years ago

@xou good point. I'll try to change the typespec instead and make a new PR