xou / elixlsx

An Elixir XLSX writer
MIT License
293 stars 116 forks source link

fix Sheet.add_data_validations typespec #154

Closed rodrigues closed 2 months ago

rodrigues commented 3 months ago

Hi 👋

This PR fixes Sheet.add_data_validations typespec, including currently supported use case when instead of a values list the user passes one string with a reference within excel (e.g. "RefSheet!$A$2:$A$32").

The function call will not succeed.

Elixlsx.Sheet.add_data_validations(_sheet :: any(), <<_::8, _::size(1)>>, <<_::8, _::size(1)>>, <<_::8, _::size(1)>>)

breaks the contract
(t(), String.t(), String.t(), [String.t()]) :: t()

Thanks!

xou commented 2 months ago

thank you!