search

xou816 / spot

Native Spotify client for the GNOME desktop
MIT License
2.32k stars 126 forks source link

Adaptive layout not showing song list #521

Open aniketfuryrocks opened 2 years ago

aniketfuryrocks commented 2 years ago

https://user-images.githubusercontent.com/42654595/167087981-5a86af94-6ee4-40a7-8f14-6c6dc41b62a8.mp4

XGZepto commented 1 year ago

I think somewhere around this commit introduced this issue (along with #520 #545).

I've been checking the logic involving navigation and sidebar but it's a bit on the complicate side tho.

xou816 commented 1 year ago

I have/had been reworking various related things in #590 it seems to be better for this? if someone can confirm with a CI build?

XGZepto commented 1 year ago

I did a test run and now the song list is indeed showing up; The navigation is still a bit messy; it's pushing library first then the playlist.

Screencast from 2023-02-17 14-33-20.webm

I'm actually thinking about whether a flap would handle the adaptive layout better than leaflet, since the user will expect the playback control to be visible the whole time.

xou816 commented 1 year ago

might be worth exploring flaps indeed, but I'm not sure how it handles split headerbars?

so I'll merge that branch soon

I still have the issue with search, but I can't see whats wrong with it for now

XGZepto commented 1 year ago

i think with flaps u cannot have split headerbars tho.