search

xou816 / spot

Native Spotify client for the GNOME desktop
MIT License
2.24k stars 118 forks source link

Cover buttons shouldn't take up entire width #678

Closed hwittenborn closed 2 months ago

hwittenborn commented 10 months ago

This is a bit of a personal choice thing, but I was thinking it's what was intended.

Cover buttons currently take up the entire available vertical width:

image

Using the GTK debugger, it appears that setting valign to GTK_ALIGN_START fixes the issue:

image

I can open a PR for this if needed (it looks like all that would need changed is valign being set at https://github.com/xou816/spot/blob/cbd3140263e07e31cb5a742d77e850106073b410/src/app/components/album/album.blp#L5-L7), but I thought I'd get it discussed here first.

hwittenborn commented 10 months ago

Nevermind, it looks like https://github.com/xou816/spot/pull/677 fixes the issue just fine.

Diegovsky commented 2 months ago

Not a personal preference, it looks objectively better with the fix applied!