search

xou816 / spot

Native Spotify client for the GNOME desktop
MIT License
2.24k stars 118 forks source link

Fix ci error #684

Closed Diegovsky closed 7 months ago

Diegovsky commented 8 months ago

Finally, it passes! @knokelmaat @xou816 could any of you please review the changes?

To summarize what I did: I updated ALL Cargo.lock dependencies with cargo update. I don't see a reason not to since we have a bunch of tests and semver guarantees it is fine to do so.

Also, updating in general is good for security. Some of the security problems raised by dependabot were solved just by doing so, I think.

Diegovsky commented 8 months ago

Thank you for the review @nmschulte. Would you happen to know why it can't be merged yet despite you approving it? (I'm not very experienced when it comes to PRs...)

nmschulte commented 8 months ago

Would you happen to know why it can't be merged yet despite you approving it? (I'm not very experienced when it comes to PRs...)

Because I'm just a rando wizard with no power here, unfortunately. We need some greybeards ... https://www.youtube.com/watch?v=m_mPE9gcQJo

Diegovsky commented 8 months ago

That's unfortunate

k1gen commented 7 months ago

it still doesn't pass for me on Arch, rust 1.74.0. here's the testlog: https://0x0.st/HvRW.txt