search

xou816 / spot

Native Spotify client for the GNOME desktop
MIT License
2.24k stars 118 forks source link

Bug Fix: Handle null images for playlist #716

Open potatoes1286 opened 1 week ago

potatoes1286 commented 1 week ago

Fixes #715, potentially #713

If a user has a playlist with no image (due to only local songs, no songs in playlist, etc), Spotify API returns a null for image and causes Spot to fail loading any playlist changes.

This turns images to an option and, if null, returns an empty image instead. It is a quick and dirty fix, but I do not know much Rust, so I've done what I could.

Thank you in advance.

@xou816

potatoes1286 commented 3 days ago

@Diegovsky @knokelmaat

Diegovsky commented 2 days ago

sorry for not seeing this earlier, I'm usually busy with my job so I don't receive notifications from gh's PRs

I'll look at it later today

Diegovsky commented 2 days ago

Also, try to target the maintenance branch as that's where current development is going

potatoes1286 commented 2 days ago

I see. My apoligies, I will try to fix that.