search

xoudini / emojica

A Swift framework for using custom emoji in strings.
Apache License 2.0
106 stars 15 forks source link

Some emojis do not work #5

Closed chriswill0w closed 6 years ago

chriswill0w commented 7 years ago

Some of the emojis which can be found here https://getemoji.com in the section "New 2017 Emojis released in June 2017" are not detected at all or are detected as "two emojis" (face plus modifier). furthermore a lot of the people emojis with skin color modifier are detected incorrectly and rendered as two emojis (face plus modifier). How can I fix this? btw why are some huge blocks commented out in the Unicode.swift file?

I am using twemoji image files as they are supplied in the twemoji repo. I did not change the file names. Tested with iOS 11.

xoudini commented 7 years ago

Yes, admittedly the Unicode 10 standard hasn't been implemented into the framework as of now, but I'll make sure to do that as soon as possible (give it a week or so). I'll also look into Emoji 5.0 specifics at the same time.

As for the 'huge blocks' commented out in the Unicode.swift file: the code points present in the ignored code are accounted for in other methods. The commented blocks are somewhat specialised and aren't really essential to the functionality of the framework, you can read a more detailed description at line 1262 onwards in the same file.

chriswill0w commented 7 years ago

sound great, thanks! do you have any idea why all the emojis with the skin and gender modifiers (should have been included already before Unicode 10, right?) do not seem to work? can you confirm that?

xoudini commented 7 years ago

@ltblueberry0 I'll have to look into it, so give me a day or two to investigate. If you could give me specific code points at which the conversion fails, that would be very helpful.

chriswill0w commented 7 years ago

most of these emojis are not working (same for other skin tones):

let emojica = Emojica()
somelabel.attributedText = emojica.convert(string: " 👱🏾‍♀️ 👱🏾 👴🏾 👵🏾 👲🏾 👳🏾‍♀️ 👳🏾 👮🏾‍♀️ 👮🏾 👷🏾‍♀️ 👷🏾 💂🏾‍♀️ 💂🏾 🕵🏾‍♀️ 🕵🏾 👩🏾‍⚕️ 👨🏾‍⚕️ 👩🏾‍🌾 👨🏾‍🌾 👩🏾‍🍳 👨🏾‍🍳 👩🏾‍🎓 👨🏾‍🎓 👩🏾‍🎤 👨🏾‍🎤 👩🏾‍🏫 👨🏾‍🏫 👩🏾‍🏭 👨🏾‍🏭 👩🏾‍💻 👨🏾‍💻 👩🏾‍💼 👨🏾‍💼 👩🏾‍🔧 👨🏾‍🔧 👩🏾‍🔬 👨🏾‍🔬 👩🏾‍🎨 👨🏾‍🎨 👩🏾‍🚒 👨🏾‍🚒 👩🏾‍✈️ 👨🏾‍✈️ 👩🏾‍🚀 👨🏾‍🚀 👩🏾‍⚖️ 👨🏾‍⚖️ 🤶🏾 🎅🏾 👸🏾 🤴🏾 👰🏾 🤵🏾 👼🏾 🤰🏾 🙇🏾‍♀️ 🙇🏾 💁🏾 💁🏾‍♂️ 🙅🏾 🙅🏾‍♂️ 🙆🏾 🙆🏾‍♂️ 🙋🏾 🙋🏾‍♂️ 🤦🏾‍♀️ 🤦🏾‍♂️ 🤷🏾‍♀️ 🤷🏾‍♂️ 🙎🏾 🙎🏾‍♂️ 🙍🏾 🙍🏾‍♂️ 💇🏾 💇🏾‍♂️ 💆🏾 💆🏾‍♂️ 🕴🏾 💃🏾 🕺🏾 🚶🏾‍♀️ 🚶🏾 🏃🏾‍♀️ 🏃🏾 🏋🏾‍♀️ 🏋🏾 🤸🏾‍♀️ 🤸🏾‍♂️ ⛹🏾‍♀️ ⛹🏾 🤾🏾‍♀️ 🤾🏾‍♂️ 🏌🏾‍♀️ 🏌🏾 🏄🏾‍♀️ 🏄🏾 🏊🏾‍♀️ 🏊🏾 🤽🏾‍♀️ 🤽🏾‍♂️ 🚣🏾‍♀️ 🚣🏾 🏇🏾 🚴🏾‍♀️ 🚴🏾 🚵🏾‍♀️ 🚵🏾 🤹🏾‍♀️ 🤹🏾‍♂️ 🛀🏾")

(scroll to the right ;-))

using unmodified icons from twemoji

xoudini commented 7 years ago

Thanks! I'll get back to you shortly.

chriswill0w commented 7 years ago

some more info: for this example 

let emojica = Emojica()
var test123 = emojica.convert(string: "👱🏾‍♀️👱🏾")

renders 4 images instead of two. it shows 3 images for the woman and one correct one for the man.

events: private func replacement(for emoji: EmojiHandler) -> NSAttributedString? -> name "1f471-1f3fe-2640" -> no image found private func fallback(for emoji: EmojiHandler) -> NSAttributedString -> name "2640" -> image found -> name "1f3fe" -> image found -> name "1f471" -> image found private func replacement(for emoji: EmojiHandler) -> NSAttributedString? -> name "1f471-1f3fe.png" -> image found

xoudini commented 7 years ago

@ltblueberry0

All of the above should now work with the version on the master branch, and I pushed the update to Cocoapods as well.

I'll also fix the warnings as soon as possible, so don't panic.

xoudini commented 7 years ago

And as for this:

I am using twemoji image files as they are supplied in the twemoji repo. I did not change the file names.

You'll need to run the renaming script for all twemoji glyphs to work properly, just follow the instructions here.