xournalpp / xournalpp

Xournal++ is a handwriting notetaking software with PDF annotation support. Written in C++ with GTK3, supporting Linux (e.g. Ubuntu, Debian, Arch, SUSE), macOS and Windows 10. Supports pen input from devices such as Wacom Tablets.
https://xournalpp.github.io
GNU General Public License v2.0
10.87k stars 788 forks source link

Customized load path for pdf annotations #2774

Open jcguu95 opened 3 years ago

jcguu95 commented 3 years ago

Is your feature request related to a problem? Please describe. It'd be nice if I can have one or multiple load paths for pdf annotations.

Describe the solution you'd like Allow user to add load path to xournalpp. Upon launching a pdf file, xournalpp will search ./ and /load/path/1 /load/path/2.. in sequence.

anti-destiny commented 3 years ago

Agree with you. A search path may be helpful for advanced users. I'd like to (humbly) suggest also adding a search depth option to allow Xournal++ to automatically look for corresponding background pdfs in subdirectories. It would be especially useful for Zotero users, which do not allow multiple files to exist in the same folder. For example, my Zotero storage folder looks like this:

├── 27C25TX2
│   └── (TBA) Tracking by Animation, Unsupervised Learning of Multi-Object Attentive Trackers.pdf.xopp
├── 2DKNG9EM
│   └── Chen 等。 - 2021 - You Only Look One-level Feature.pdf
├── 2PR6FNRC
│   └── Girshick_Fast_R-CNN_ICCV_2015_paper.pdf
├── 2ZCAIXVW
│   └── 2101.html

So once the files are synchronized and opened in another device, it'll produce a warning about "missing background file". But the problem can be solved by providing a search path and a search depth = 2.

hyperupcall commented 1 year ago

I don't think this will improve the experience for xournalpp - By adding a search path, the process of loading a PDF file will be more ambiguous to the user - users with different search paths may even experience different behaviors if the same xournalpp file is opened.

@anti-destiny The missing background file will be solved by #4262. Once your files are re-saved, it will be saved as a relative path, so if you open the file under a different device, things should Just Work.

So my vote is to close this issue - the feature seems to be a workaround for a different problem that will soon be fixed, and if implemented alone, it will make things much less clear when loading background PDFs and such.