search

xoxfaby / BetterUI

Risk of Rain 2 mod BetterUI
Other
62 stars 34 forks source link

Void Fiend Text Error #115

Closed JamesTripleQ closed 1 year ago

JamesTripleQ commented 2 years ago

Describe the bug The description for Void Fiend's Special is always it's corrupted variant both on the lobby menu and when hovering over the skill in-game.

Does the error occur when only using BetterUI and no other mods? This error seems to be entirely tied to BetterUI and more specifically the AdvancedIcon component since disabling that fixes the issue.

BetterUI Version 2.5.10

xoxfaby commented 2 years ago

Can you confirm what happens in VANILLA?

I added extra skill tokens because in vanilla, both forms bad exactly the same ones.

Idk if this has changed

JamesTripleQ commented 2 years ago

Vanilla image With BetterUI image

xoxfaby commented 2 years ago

I see, this is strange, what about in-game?

JamesTripleQ commented 2 years ago

Same thing in game... Vanilla has the normal one and BetterUI always has the corrupted version

JamesTripleQ commented 2 years ago

Sorry I couldn't get the screenshots earlier

Vanilla image

With BetterUI image

JamesTripleQ commented 2 years ago

I'm no modder for this game so I'm probably wrong but I think that the error lies in line 73 of AdvancedIcons.cs, it mentions "CrushCorruption" but that is the name of the un-corrupted skill... I think you might need to change that to the corrupted version. What I think is happening is that ypu accidentally set it to display the Corrupted Suppress description on the normal Suppress

JamesTripleQ commented 2 years ago

I also just noticed that the Corrupt Suppress is also wrong and displays the normal Suppress image

xoxfaby commented 1 year ago

Pretty sure I fixed this, if I haven't please reopen this issue

JamesTripleQ commented 1 year ago

Hi, sorry this still seems to happen even on the latest version of BetterUI. I cannot re-open the issue myself as it was closed by you.

xoxfaby commented 1 year ago

I tested this today and it was working correctly, in Vanilla there is only 1 description and with BetterUI it shows the correct ones.

xoxfaby commented 1 year ago

What language do you play in?

xoxfaby commented 1 year ago

Please also provide a log, until then the issue remains closed again

JamesTripleQ commented 1 year ago

My PC's language is Italian but my game is in English.

The following three screenshots DO NOT have BetterUI:

image image image

These next few screenshots are WITH BetterUI:

image image image

There are a few things to note: 1) in all images of BetterUI the text for Suppress and Corrupted Suppress (Still called Suppress in game) is swapped: in the character select menu both the skill name and "[Corruption Upgrade]" text are swapped, and it's like that in the Tab menu descriptions too. 2) in the 3rd NON BetterUI image the Corrupted Suppress text hasn't changed from the regular Suppress text, this seems to be something the devs never implemented

JamesTripleQ commented 1 year ago

As for the log here it is however it also has other mods enabled since, I don't know why, but disabling them seems to corrupt my save LogOutput.log

xoxfaby commented 1 year ago

Yeah, so the Vanilla behaviour doesn't have any text for the other skills because this is a feature of BetterUI, the risk of rain 2 dev forgot I guess and BetterUI specifically adds extra text for those skills. As for BetterUI, it seems that Suppress is backwards yeah, now with this more detailed info I was able to confirm what you're seeing because I misunderstood before and thought you meant that all skills were backwards. Thank you so much for your bug report and detailed info.

I will close this issue when I've deployed the patch that fixes this.