xoxfaby / BetterUI

Risk of Rain 2 mod BetterUI
Other
59 stars 33 forks source link

Better UI calculating CDR on skills one pickup later. #123

Closed Ner0ls closed 1 year ago

Ner0ls commented 2 years ago

Describe the bug Better UI calculating CDR on skills one pickup later, or one "inventoryChange" later.

Link your log file https://pastebin.com/WPEWk4vf

Does the error occur when only using BetterUI and no other mods? Yes it does, I've loaded the bare minimum:

BetterUI Version 2.5.12

Additional information After picking up a CDR item, any pickup will "properly set" CDR on skills, the same behavior occurs with losing a CDR item, it won't update CDR on skills until another refresh of inventory.

Here you can see Alien Head not properly applying the CDR calculations. 20220428103406_1

One item later, it does: 20220428103412_1

The same when I lose it, it keeps the CDR: 20220428103658_1

Until another pickup: 20220428103725_1

Final notes:

xoxfaby commented 1 year ago

I don't remember if I fixed this, if I haven't please reopen this issue.