search

xoxfaby / BetterUI

Risk of Rain 2 mod BetterUI
Other
62 stars 34 forks source link

0 Second fix #158

Closed Damglador closed 1 year ago

Damglador commented 1 year ago

So mod displays on 0 second - "BETTERUI_SECOND", but on Ukrainian we cant say 0 second, we're saying 0 seconds, so better just leave "с".

github-actions[bot] commented 1 year ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Damglador commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

xoxfaby commented 1 year ago

I think the better fix for this is to show the plural message below 1 second

Damglador commented 1 year ago

I think the better fix for this is to show the plural message below 1 second

No, that must remain as it is.

xoxfaby commented 1 year ago

Why?

Damglador commented 1 year ago

Why?

Bcs then I must change all to just "с" cause of same problem that I described in PR description

xoxfaby commented 1 year ago

Why? anything other than 1 would be "BETTERUI_SECONDS", and 1 would be "BETTERUI_SECOND"

Which sounds like the correct behaviour? Do you have a different word for 0 and 2+? If so I can implement that.

Damglador commented 1 year ago

"секунди" for 0-1, "секунд" for 0, "секунду" for 1 and "секунд" for others. Something like that

xoxfaby commented 1 year ago

so

0 секунд 0.1 секунди 0.99 секунди 1 секунду 1.5 секунд 2 секунд 100000 секунд

?

Damglador commented 1 year ago

should be "1,5 секунди", other is right

xoxfaby commented 1 year ago

what about 2.5 ?

Damglador commented 1 year ago

Same, секунди

xoxfaby commented 1 year ago

Same as 1.5?

so anything with a decimal is "секунди"?

Damglador commented 1 year ago

Yep

xoxfaby commented 1 year ago

okay so

BETTERUI_SECOND BETTERUI_SECONDS BETTERUI_SECONDS_ZERO BETTERUI_SECONDS_DECIMAL

would be enough to cover what you need?

Damglador commented 1 year ago

I think yes

Damglador commented 1 year ago

so

0 секунд 0.1 секунди 0.99 секунди 1 секунду 1.5 секунд 2 секунд 100000 секунд

?

Little improvement 2-4 секунди 5+ секунд (With decimals, still секунди)

xoxfaby commented 1 year ago

so 0 секунд 0.1 секунди 0.99 секунди 1 секунду 1.5 секунд 2 секунд 100000 секунд ?

Little improvement 2-4 секунди 5+ секунд (With decimals, still секунди)

I thought you said it should be 2 секунд?

Damglador commented 1 year ago

so 0 секунд 0.1 секунди 0.99 секунди 1 секунду 1.5 секунд 2 секунд 100000 секунд ?

Little improvement 2-4 секунди 5+ секунд (With decimals, still секунди)

I thought you said it should be 2 секунд?

I was wrong

xoxfaby commented 1 year ago

Implemented this with the new logic added in f13ce4e, if something is missing feel free to create another PR