xp-framework / core

The XP Framework is an all-purpose, object oriented PHP framework.
Other
19 stars 6 forks source link

PHP 8.1: offset* signature #276

Closed thekid closed 3 years ago

thekid commented 3 years ago

With recent PHP 8.1 builds, the following notice occurs:

Return type of util\Bytes::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

This was suggested in https://wiki.php.net/rfc/internal_method_return_types and introduced in https://github.com/php/php-src/pull/7251

For the moment, adding #[ReturnTypeWillChange] seems like the way to go.

thekid commented 3 years ago

Fixed w/ some additional commits, see https://github.com/xp-framework/core/actions/runs/1064453514

thekid commented 3 years ago

Released in https://github.com/xp-framework/core/releases/tag/v10.11.1