search

xp-framework / core

The XP Framework is an all-purpose, object oriented PHP framework.
Other
19 stars 6 forks source link

Deprecate XP annotation syntax #284

Closed thekid closed 2 years ago

thekid commented 2 years ago

The following code (which creates a parse error in PHP 8!) will throw deprecation warnings with PHP 7 when accessing annotations reflectively.

class DemoTest {

  #[@test]
  public function can_create_demo() {
    // ...
  }
}

Causes E_USER_DEPRECATED: "XP annotation syntax is deprecated in DemoTest, line 6"

Part 2 of xp-framework/rfc#336

thekid commented 2 years ago

Tests are currently failing for some weird and unreproducible reason, see #285

Temporary issue with Github actions, fixed now.