search

xp-framework / core

The XP Framework is an all-purpose, object oriented PHP framework.
Other
19 stars 6 forks source link

Use COMPOSER_ROOT_VERSION and add dependency instead of bundling test library #330

Closed thekid closed 1 year ago

thekid commented 1 year ago

See https://github.com/orgs/xp-framework/projects/3/views/1?layout=board&pane=issue&itemId=20270441

thekid commented 1 year ago

First try at this fails with the following error:

Uncaught exception: Error (Class "lang\ClassLoader" not found)
  at <source> [line 3 of .\vendor\xp-framework\unittest\src\main\php\autoload.php]
  at <main>('xp.runtime.Version') [line 0 of class-main.php]
  at <main>::require() [line 41 of autoload_real.php]
  at <main>::{closure}('f7e7399f4bd474d3487a635120d30672', ...) [line 45 of autoload_real.php]
  at ComposerAutoloaderInitf8038e3deb1574925d9777836247bfbf::getLoader() [line 25 of autoload.php]
  at <main>::require('...\\vendor\\autoload.php') [line 327 of class-main.php]

...which is due to the fact that all files inside path files will be loaded first.

thekid commented 1 year ago

✅ https://ci.appveyor.com/project/thekid/core/builds/47388335 ✅ https://github.com/xp-framework/core/actions/runs/5369301599/jobs/9740632560?pr=330