search

xpack-dev-tools / openocd-xpack

A binary distribution of OpenOCD
https://xpack-dev-tools.github.io/openocd-xpack/
MIT License
333 stars 57 forks source link

README: fix typo #26

Closed zqb-all closed 1 year ago

ilg-ul commented 1 year ago

Thank you!

ilg-ul commented 1 year ago

Mark @zqb-all, in the xpack-develop branch there were some changes to the README-DEVELOPER file. I merged them into the xpack branch after applying your PR.

Could you review the new version, both for content and typos? Thank you!

zqb-all commented 1 year ago

Sure. I just read it over and don't see any problems.

ilg-ul commented 1 year ago

Do you think that the instructions are correct and clear enough for first time readers, in order to successfully run a build on their machines? Did you do this? Was it successful?

zqb-all commented 1 year ago

I think it's clear enough，I ran into this problem the first time I compiled: https://github.com/xpack-dev-tools/openocd-xpack/issues/25 The problem was solved with your help and is works well now

ilg-ul commented 1 year ago

I think it's clear enough，

Ok.

I ran into this problem the first time I compiled: https://github.com/xpack-dev-tools/openocd-xpack/issues/25 The problem was solved with your help and is works well now

Yes, but by that time the README-DEVELOPER was not available, and you used the more complicated instructions in the README-MAINTAINER file; plus that you faced some download failures, which were later fixed with some fixes in xpm.

Now things should be easier with the new instructions in README-DEVELOPER.

The question was in fact related to the new instructions.