xpack / xpm-js

The xPack Project Manager command line tool
https://xpack.github.io/xpm/
MIT License
29 stars 7 forks source link

`xpm uninstall` does not remove `*.ps1` PowerShell scripts/shims #201

Open TommyMurphyTM1234 opened 1 month ago

TommyMurphyTM1234 commented 1 month ago

Describe the bug

xpm uninstall ... doesn't seem to remove *.ps1 PowerShell scripts/shims that are part of the installed xPack package.

I think that this is an xpm issue and not an issue with the specific xPack package that I used below (xPack GNU RISC-V Embedded GCC)

To Reproduce

I did this on Windows 10:

mkdir test
cd test

xpm init

xpm install @xpack-dev-tools/riscv-none-elf-gcc@latest --verbose
xPack manager - install package(s)

Processing @xpack-dev-tools/riscv-none-elf-gcc@14.1.0-1.1...
Adding to central store 'C:\Users\Tommy Murphy\AppData\Roaming\xPacks\@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1'...
Extracting 'xpack-riscv-none-elf-gcc-14.1.0-1-win32-x64.zip'...
6398 files extracted in '14.1.0-1.1/.content'
Changing permissions to read-only...
Folder 'xpacks\@xpack-dev-tools\riscv-none-elf-gcc' linked to global '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1'
File 'xpacks\.bin\riscv-none-elf-addr2line.cmd' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-addr2line.exe'
File 'xpacks\.bin\riscv-none-elf-addr2line.ps1' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-addr2line.exe'
File 'xpacks\.bin\riscv-none-elf-addr2line' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-addr2line.exe'
...
File 'xpacks\.bin\riscv-none-elf-strip.cmd' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-strip.exe'
File 'xpacks\.bin\riscv-none-elf-strip.ps1' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-strip.exe'
File 'xpacks\.bin\riscv-none-elf-strip' forwarding to '@xpack-dev-tools\riscv-none-elf-gcc\14.1.0-1.1\.content\bin\riscv-none-elf-strip.exe'
Adding '@xpack-dev-tools/riscv-none-elf-gcc' to 'devDependencies'...

'xpm install' completed in 71.820 sec.

xpm list

- @xpack-dev-tools/riscv-none-elf-gcc@14.1.0-1.1
  A binary xPack with the GNU RISC-V Embedded GCC executables

- xpacks/.bin/riscv-none-elf-addr2line
- xpacks/.bin/riscv-none-elf-addr2line.cmd
- xpacks/.bin/riscv-none-elf-addr2line.ps1
...
- xpacks/.bin/riscv-none-elf-strip
- xpacks/.bin/riscv-none-elf-strip.cmd
- xpacks/.bin/riscv-none-elf-strip.ps1

xpm uninstall @xpack-dev-tools/riscv-none-elf-gcc@latest --verbose
xPack manager - uninstall package(s)

Shim 'xpacks\.bin\riscv-none-elf-addr2line.cmd' removed
Script 'xpacks\.bin\riscv-none-elf-addr2line' removed
...
Shim 'xpacks\.bin\riscv-none-elf-strip.cmd' removed
Script 'xpacks\.bin\riscv-none-elf-strip' removed
Symlink 'xpacks/@xpack-dev-tools/riscv-none-elf-gcc' removed
package.json devDependencies['@xpack-dev-tools/riscv-none-elf-gcc'] removed

'xpm uninstall' completed in 387 ms.

xpm list

- xpacks/.bin/riscv-none-elf-addr2line.ps1
- xpacks/.bin/riscv-none-elf-ar.ps1
- xpacks/.bin/riscv-none-elf-as.ps1
- xpacks/.bin/riscv-none-elf-c++.ps1
- xpacks/.bin/riscv-none-elf-c++filt.ps1
- xpacks/.bin/riscv-none-elf-cpp.ps1
- xpacks/.bin/riscv-none-elf-elfedit.ps1
- xpacks/.bin/riscv-none-elf-g++.ps1
- xpacks/.bin/riscv-none-elf-gcc-ar.ps1
- xpacks/.bin/riscv-none-elf-gcc-nm.ps1
- xpacks/.bin/riscv-none-elf-gcc-ranlib.ps1
- xpacks/.bin/riscv-none-elf-gcc.ps1
- xpacks/.bin/riscv-none-elf-gcov-dump.ps1
- xpacks/.bin/riscv-none-elf-gcov-tool.ps1
- xpacks/.bin/riscv-none-elf-gcov.ps1
- xpacks/.bin/riscv-none-elf-gdb-add-index-py3.ps1
- xpacks/.bin/riscv-none-elf-gdb-add-index.ps1
- xpacks/.bin/riscv-none-elf-gdb-py3.ps1
- xpacks/.bin/riscv-none-elf-gdb.ps1
- xpacks/.bin/riscv-none-elf-gfortran.ps1
- xpacks/.bin/riscv-none-elf-gprof.ps1
- xpacks/.bin/riscv-none-elf-ld.ps1
- xpacks/.bin/riscv-none-elf-lto-dump.ps1
- xpacks/.bin/riscv-none-elf-nm.ps1
- xpacks/.bin/riscv-none-elf-objcopy.ps1
- xpacks/.bin/riscv-none-elf-objdump.ps1
- xpacks/.bin/riscv-none-elf-ranlib.ps1
- xpacks/.bin/riscv-none-elf-readelf.ps1
- xpacks/.bin/riscv-none-elf-size.ps1
- xpacks/.bin/riscv-none-elf-strings.ps1
- xpacks/.bin/riscv-none-elf-strip.ps1

Expected behaviour

All scripts/shims in the project directory should be removed - including the *.ps1 PowerShell scripts/shims.

Actual behaviour

The PowerShell scripts/shims are left behind.

Context

npm doctor
Connecting to the registry
Ok

Checking npm version
Not ok
Use npm v10.8.2

Checking node version
Ok
current: v20.16.0, recommended: v20.16.0

Checking configured npm registry
Ok
using default registry (https://registry.npmjs.org/)

Checking for git executable in PATH
Ok
C:\Program Files\Git\cmd\git.EXE

Checking for global bin folder in PATH
Ok
C:\Users\Tommy Murphy\AppData\Roaming\npm

npm error Some problems found. See above for recommendations.
npm error A complete log of this run can be found in: C:\Users\Tommy Murphy\AppData\Local\npm-cache\_logs\2024-07-30T20_34_55_312Z-debug-0.log
ilg-ul commented 1 month ago

Thank you. Definitely a bug.