search

xparq / AnimGif

PHP class to create an animated GIF from multiple images
89 stars 24 forks source link

Issues with PHP 8.0.8 #10

Open Alan-raceqs opened 2 years ago

Alan-raceqs commented 2 years ago

Brilliant piece of work, many thanks. Couple of little issues from PHP, there are still quite a few instances of curly brackets being used for array offsets that generate

PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported Which I fixed by replacing {}'s with []'s.

And I was unable to pass my image (from imageCreateTrueColor) to the array, it failed with:

PHP Fatal error: Uncaught Exception: 1.3+: Only image resource variables, file paths, URLs or binary bitmap data are accepted. So I had to pass the filename of the png, but otherwise it's good.

PHP 8.0.8 (cli) (built: Jul 12 2021 11:13:36) ( NTS ) on MacOS Monterey

d4rkd0s commented 2 years ago

@Alan-raceqs where did you "Which I fixed by replacing {}'s with []'s."

If you have a fork/branch I'd be interested I'm about to do the same work myself.

I use this as a dependency on https://github.com/d4rkd0s/phpfisx

Much thanks in advance! (also for opening this issue on this repo 👍🏻)

Alan-raceqs commented 2 years ago

I’m not a GitHub contributor, I hoped the author would have implemented a fix. Here’s the modified code that works for me.

Cheers, Alan

On 11 May 2022, at 1:44 pm, Logan Schmidt @.***> wrote:

@Alan-raceqs https://github.com/Alan-raceqs where did you "Which I fixed by replacing {}'s with []'s."

If you have a fork/branch I'd be interested I'm about to do the same work myself.

I use this as a dependency on https://github.com/d4rkd0s/phpfisx https://github.com/d4rkd0s/phpfisx Much thanks in advance! (also for opening this issue on this repo 👍🏻)

— Reply to this email directly, view it on GitHub https://github.com/lunakid/AnimGif/issues/10#issuecomment-1123148006, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYJBS7UIIDE6EOOOO7DCWATVJMUJDANCNFSM5RAR2LQQ. You are receiving this because you were mentioned.

d4rkd0s commented 2 years ago

Yeah all good @Alan-raceqs

For ref, if anyone else is curious what the changes are, I got it patched up here: https://github.com/d4rkd0s/animgif/commit/4dd151cbe40bd39bca5b0920e658130663a381d4 for my fork here https://github.com/d4rkd0s/phpfisx/commit/2ae0edd541156ce2d31b66df33c4197cfd798893

dgriggs125 commented 5 months ago

Updated version that works with PHP 8.0.30 and the GD 2.1.0 extension attached, for those who find it useful. Very helpful library, sorry I don't know how to update GitHub. AnimGif.txt