search

xpavle00 / Habo

Habo is an open-source habit tracker. Created in a flutter.
https://habo.space
GNU General Public License v3.0
422 stars 63 forks source link

Adaptive icon support #23

Closed lokesh-krishna closed 1 year ago

lokesh-krishna commented 1 year ago

Would be really nice to have adaptive icons support.

xpavle00 commented 1 year ago

Hey, adaptive icons should be supported.

lokesh-krishna commented 1 year ago

Do you mean it's already supported? On my Pixel 6 running Android 13 (GrapheneOS), this is what the icon looks like:

Screenshot_20230422-020906

As you can see, the icon is not adaptive.

xpavle00 commented 1 year ago

It looks the same as for example Gmail icon. If you think themed icons, that applies only to desktop icons in 13. https://proandroiddev.com/android-13-implementing-themed-icons-into-your-app-e7002f2c4e04

lokesh-krishna commented 1 year ago

It doesn't because Gmail provides a background layer (in this case, white). If Habo provided an actual background layer, we'd have a green background instead of the white background upon which the actual icon sits.

xpavle00 commented 1 year ago

Habo provides also white background with green icon.

lokesh-krishna commented 1 year ago

The idea with the adaptive icon is that you have a background and a foreground. I don't think Habo is providing a background. So the icon as a whole is being set upon the white background. Habo has a green background, which if provided as a separate background would make an adaptive icon possible.

xpavle00 commented 1 year ago

Habos logo is a green square with a white checkmark. A square is also important, it is not just a checkmark. This is intended. I provide a white background and it should be similar to for example Gmail or Docs on your screen. If you look at UI guide you provided, a star shape is also in the foreground, with an android. The same idea is here, the Habo logo is foreground and it is set up to have a white background.

lokesh-krishna commented 1 year ago

Ah, understood!