F-Droid inclusion - Githubissues

xpavle00 / Habo

Habo is an open-source habit tracker. Created in a flutter.

https://habo.space

GNU General Public License v3.0

436 stars 68 forks source link

F-Droid inclusion #6

Open shuvashish76 opened 2 years ago

shuvashish76 commented 2 years ago

A request for packaging has been opened here: https://gitlab.com/fdroid/rfp/-/issues/1881

shuvashish76 commented 2 years ago

Hello @xpavle00 need your permisson for F-Droid inclusion.

F-Droid requirements

[ ] Add Fastlane structures to the repository as described here.

shuvashish76 commented 2 years ago

@xpavle00

https://gitlab.com/fdroid/rfp/-/issues/1881#note_898144307

IzzySoft commented 1 year ago

If you could attach an APK to your releases (starting with the most recent one – no need for the old ones) I could at least add it to my repo. The RFP linked in the previous comment was closed due to lack of response btw; but with the app in my repo we could close some gaps (I could then e.g. provide the Fastlane structures which were asked for).

xpavle00 commented 1 year ago

Hey, Sorry I did not have the capacity to solve this earlier. But I added APK to the newest release.

IzzySoft commented 1 year ago

Thanks a lot! Quite a heavy one, due to the Flutter libs. I hope I'm not overdoing it if I ask for per-ABI builds? Those would then be around 10..12 MB each. In turn I'd offer to take your app into my F-Droid repo to make it easier accessible (and discoverable). Going by the results of my library scanner, your app should also qualify for inclusion with F-Droid.org itselt – so one alternative could be applying for inclusion there. In that case, F-Droid would take care for building the APKs.

xpavle00 commented 1 year ago

Hi, I did per-abi build and attached it to the release. Hope it will work :)

IzzySoft commented 1 year ago

Like a charm, thanks! What to expect here with the next sync around 7 pm UTC:

I've picked the armeabi build, which allows for most wide compatibility (as long as some arm64 device manufacturer did not decide to disable 32bit support) and, for now, lets me keep 3 versions available (will have to reduce that to 2 versions at some point, expecting the APK to grow with future releases).

So once more, feel encouraged to apply at F-Droid.org – looks like your app meets the inclusion criteria! Oops: I see @shuvashish76 already had opened one a while ago which we had to close due to lack of response. The open point was missing Fastlane. Well, that can be helped if you want: would you accept a corresponding PR (I could send you what I have set up here a few minutes ago), and support the inclusion with F-Droid? Then that RFP can be reopened (disclosure: I'm one of the F-Droid maintainers, so i can do that). F-Droid would then ship all 4 per-ABI builds.

IzzySoft commented 7 months ago

@xpavle00 v2.1.0 added two proprietary components: Google Play Core and GMS. That makes the app ineligible for F-Droid, and will get an AntiFeature in my repo. Was that intended? If so, why – and would you consider reverting that? If not intentional, please try finding out what brought them in (running flutter pub deps should help there) and eliminate it again. Thanks!

xpavle00 commented 7 months ago

Hey, I added https://pub.dev/packages/in_app_review package. Probably it caused that. Didn't know it had these components. I will revert it and create new builds.

IzzySoft commented 7 months ago

Ah, exactly the one I thought you might have added. Yes, confirmed: that drags in Google Play Core, which then drags in GMS. Bad choice, and not very useful anyway (better link to the app in Play to let people rate it there) and not worth the tainting IMHO, but YMMV…