xpdAcq / mission-control

Releases, Installers, Specs, and more!
0 stars 4 forks source link

Include gas_plan compatible to xpdAcq plan protocol #143

Open sghose opened 5 years ago

sghose commented 5 years ago

Expected Behavior

There are two Blue Sky plans exists in the XPD/Startup directory under 999-plans.py One called gas_plan and other one called gas_plan_with_detector. Need to use gas_plan along with other xpdAcq plans tseries, Tramp and use xrun.

Current Behavior

gas_plan_detector works using xrun (sample, gas_plan_detector) but all gas_plan table and plot features does not work.

gas_plan does not work to trigger sequentially for each frame combining with tseries, Tramp.

Possible Solution

Incorporate gas_plan into xpdAcq protocol similar to Tramp. Here is a link with my changes: https://github.com/NSLS-II-XPD/profile_collection/blob/master/startup/9999-acq-plans.py (the one below refers to the previous version of the file).

Context

Used by users almost every cycle until now running a script using the gas_plan function

Priority

Need for user running on Oct 10th 2018

Your Environment

Here is a link with my changes: https://github.com/NSLS-II-XPD/profile_collection/blob/master/startup/9999-acq-plans.py (the one below refers to the previous version of the file).

chiahaoliu commented 5 years ago

@sghose thanks for such detailed description about the use case. I am wondering if you would need to set the gas at each step in your temperature-series-like scan or just need to be set at the beginning?

Including live plotting to xrun can easily be done and for the tale saving, outsourcing to analysis pipeline might be a better solution.

sghose commented 5 years ago

Thanks @chiahaoliu Direct answer to your guestion is we will set the gas at the begining. But we will read the gas value and rga value for each time detector collects frames for tseries or Tramp. That means we read gas value and rga masses for each temperature or each exposure.

we would like to have the plotting of the rga masses to be done by xrun and could get the metadata saving through xpdAnn through pipeline. For now we could do it manually under xpdAnn.

chiahaoliu commented 5 years ago

Thanks for the clarification, @sghose

Based on the timeline, I suggest we break this task into two stages:

Sounds good?

sghose commented 5 years ago

Sounds Good to me. Are you going to get me the customize script or I can use the same way I did earlier? Essentially, my script, function gas_plan was just included into the startup as a BS plan. I can use gas_plan_detector in a script and do xrun on the plan.

chiahaoliu commented 5 years ago

I think I will ship you the script and you could put it either under ipython startup profile (as current gas_plan_detector) or run with specific file path

sbillinge commented 5 years ago

This is a good first project for Songsheng, in collaboration with @chiahaoliu