search

xpdAcq / mission-control

Releases, Installers, Specs, and more!
0 stars 4 forks source link

Verify and Implement all temperature controllers ( eurotherm, linkam, hot air blower) to xpdacq #164

Open adelezh opened 5 years ago

adelezh commented 5 years ago

to implement all the temperature controls (Eurotherm, Hot Air Blower, Linkam) into Tramp, Tlist, series properly similar to cs700 (cryo stream). Ophyd objects are available.

chiahaoliu commented 5 years ago

Can't this be done by setting xpd_configuration['temp_controller']?

adelezh commented 5 years ago

hot air blower is new, not in the temperature controller list yet. Also, eurotherm and linkam is not work as good as cs700

CJ-Wright commented 5 years ago

Can you elaborate on how the eurotherm and linkam are not working?

adelezh commented 5 years ago

From Sanjit: Eurotherm: It works with xpdacq. Since it does not have a readback status it does not response to detector trigger. Now in ophyd we are having a fake tolerance of +/- 1 C which could be used as read back. This is what to be implemented somehow into xpdacq to run the same way as cryostream. Tim knows this issue very well.

Also, shutter does not work the with Tramp the same way as cryo, may be for the same reason. We will test and follow this up.

The same issue may be with linkam & hotair blower.

CJ-Wright commented 5 years ago

I'm confused by

Now in ophyd we are having a fake tolerance of +/- 1 C which could be used as read back. This is what to be implemented somehow into xpdacq to run the same way as cryostream.

If the fix was implemented in ophyd for the eurotherm why does xpdacq need to be changed?

chiahaoliu commented 5 years ago

From Sanjit: Eurotherm: It works with xpdacq. Since it does not have a readback status it does not response to detector trigger. Now in ophyd we are having a fake tolerance of +/- 1 C which could be used as read back. This is what to be implemented somehow into xpdacq to run the same way as cryostream. Tim knows this issue very well.

To fill in my understanding. The problem with eurotherm is that, as stated by Sanjit, there is no done readback from the device so it can't be used as cryostream (scan won't wait for the temperature set point). The fake tolerance trick was implemented by the beamline staffs and it is actually done through scripting (while T in range, fire xrun) based on my memory. This approach is totally not encouraged and it also failed on some edge case from the last beamtime. The best and long-term approach is to fix this at ophyd level. Could we initiate a ticket with DAMA group? Also, shutter does not work the with Tramp the same way as cryo, may be for the same reason. We will test and follow this up.

Thanks. Please describe how it doesn't work as expected. We are very interested in hearing it. The same issue may be with linkam & hotair blower.

For the same reasosn stated above, in order for any device to work as cryostream, the existance of its ophyd object is not sufficient. A done readback must exist in the ophyd level.

CJ-Wright commented 5 years ago

Or potentially at the EPICS level if the same functionality is expected from CS Studio.