Add exposure to template

[st3107]

Please review and merge.

[st3107]

Thank you for comment. I modified the template.

On Fri, Oct 4, 2019 at 1:52 PM Christopher J. Wright < notifications@github.com> wrote:

@CJ-Wright commented on this pull request.

In xpdan/startup/save_server.py:

@@ -35,6 +35,7 @@ def setup_saver(doc, **kwargs): "{start[samplename]}"

The writers handle the trailing _

"{humantimestamp}"

• "{sp_computedexposure}s"

This should pull from the start document {start[...]}. It could pull from the descriptor though if that information is in the descriptor

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/277?email_source=notifications&email_token=AI27ND4HR4574GE6SEBIWX3QM57D7A5CNFSM4I5SSDX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG6WZ5Q#pullrequestreview-297626870, or mute the thread https://github.com/notifications/unsubscribe-auth/AI27ND6NAJ6MVLWP3OJR7U3QM57D7ANCNFSM4I5SSDXQ .

-- [image: photo] Songsheng Tao Ph. D. student, Columbia University

347-749-7947 Create your own email signature https://www.wisestamp.com/signature-in-email?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own

[CJ-Wright]

The tests seem to be failing and most likely need to be updated to the new string.

[st3107]

Hello, CJ. Could you tell me which test failed? I am not sure how to test the program. I run "pytest test_save_pipelines" and "pytest test_save_server" and they passed with warnings. Thank you for your help.

Sincerely, Songsheng

On Fri, Oct 4, 2019 at 5:52 PM Christopher J. Wright < notifications@github.com> wrote:

The tests seem to be failing and most likely need to be updated to the new string.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/277?email_source=notifications&email_token=AI27NDZ3D6M2ESQ424HOXK3QM63I7A5CNFSM4I5SSDX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAM7JCI#issuecomment-538571913, or mute the thread https://github.com/notifications/unsubscribe-auth/AI27ND4W4KBXYDEKOMYBNF3QM63I7ANCNFSM4I5SSDXQ .

-- [image: photo] Songsheng Tao Ph. D. student, Columbia University

347-749-7947 Create your own email signature https://www.wisestamp.com/signature-in-email?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own

[CJ-Wright]

pytest didn't fail the build failed. You'll need to pull out the orch things and use a direct conda install. you will need to condense the score.yaml which holds the requirements into a conda install ....

[codecov-io]

Codecov Report

Merging #277 into master will decrease coverage by 1.7%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   69.12%   67.41%   -1.71%     
==========================================
  Files          58       58              
  Lines        4217     4217              
==========================================
- Hits         2915     2843      -72     
- Misses       1302     1374      +72

Impacted Files	Coverage Δ
xpdan/pipelines/pipeline_utils.py	50.87% <ø> (ø)	:arrow_up:
xpdan/tests/test_pipeline_utils.py	100% <ø> (ø)	:arrow_up:
xpdan/startup/save_server.py	35.13% <ø> (ø)	:arrow_up:
xpdan/tests/pipelines/test_save_tiff_pipeline.py	95.55% <100%> (ø)	:arrow_up:
xpdan/tests/test_main_callback.py	100% <100%> (ø)	:arrow_up:
xpdan/tests/pipelines/test_save_pipeline.py	100% <100%> (ø)	:arrow_up:
xpdan/fuzzybroker.py	21.62% <0%> (-71.63%)	:arrow_down:
xpdan/tests/test_fuzzybroker.py	38.46% <0%> (-61.54%)	:arrow_down:
xpdan/tests/conftest.py	97.87% <0%> (-1.07%)	:arrow_down:
xpdan/vend/callbacks/core.py	84.88% <0%> (-0.51%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21ab4e9...31d7422. Read the comment docs.

[st3107]

No need for this now. PR is closed.