CJ-Wright commented 4 years ago

You should pull out orch if you aren't going to maintain it, it might be a bit buggy.

st3107 commented 4 years ago

Thank you for the suggestion. I pull that out.

st3107 commented 4 years ago

Hi @sbillinge Could you grant me the admin right of this repo so that I can merge PR by myself and change CI setting?

sbillinge commented 4 years ago

thanks for the hard work on this @st3107 pls let me know when you are ready to merge (or go ahead and merge yourself)

st3107 commented 4 years ago

It is not ready to merge. I am contacting CJ to see where the bugs are coming from. I fix the pickle problems but the server doesn't do the things as expected in the tests.

On Wed, Jul 22, 2020 at 6:15 PM Simon Billinge notifications@github.com wrote:

thanks for the hard work on this @st3107 https://github.com/st3107 pls let me know when you are ready to merge (or go ahead and merge yourself)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/280#issuecomment-662724618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI27NDYA3DCXD3U3AKTKJJ3R45QHNANCNFSM4O2ZFHCA .

-- [image: photo] Songsheng Tao Ph. D. student, Columbia University

347-749-7947 Create your own WiseStamp email signature https://www.wisestamp.com/signature-in-email/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=5823337284239360

codecov-commenter commented 4 years ago

Codecov Report

Merging #280 into master will decrease coverage by 3.48%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   69.12%   65.64%   -3.49%     
==========================================
  Files          58       58              
  Lines        4217     4200      -17     
==========================================
- Hits         2915     2757     -158     
- Misses       1302     1443     +141

Impacted Files	Coverage Δ
xpdan/tests/vend/test_callbacks.py	`94.15% <ø> (+25.47%)`	:arrow_up:
xpdan/vend/callbacks/mpl_plotting.py	`78.31% <ø> (+47.57%)`	:arrow_up:
xpdan/tests/startup/test_servers.py	`20.21% <52.17%> (-79.79%)`	:arrow_down:
xpdan/tests/vend/test_zmq.py	`85.62% <82.35%> (+75.44%)`	:arrow_up:
xpdan/tests/conftest.py	`92.50% <100.00%> (-6.44%)`	:arrow_down:
xpdan/pipelines/radiograph.py	`31.25% <0.00%> (-65.63%)`	:arrow_down:
xpdan/startup/peak_server.py	`26.19% <0.00%> (-61.91%)`	:arrow_down:
xpdan/startup/portable_db_server.py	`32.60% <0.00%> (-60.87%)`	:arrow_down:
xpdan/pipelines/qoi.py	`42.85% <0.00%> (-57.15%)`	:arrow_down:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21ab4e9...46a778a. Read the comment docs.

st3107 commented 4 years ago

Hi @sbillinge Could you merge this PR? Also, could you grant me the maintainer rights of this repo? Thank you.

sbillinge commented 4 years ago

ok, done.

On Wed, Jul 29, 2020 at 8:19 PM Songsheng Tao notifications@github.com wrote:

Hi @sbillinge https://github.com/sbillinge Could you merge this PR? Also, could you grant me the maintainer rights of this repo? Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/280#issuecomment-665997254, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUKIQFB36WKWLTNTJP3R6C37NANCNFSM4O2ZFHCA .

-- Professor Simon Billinge Columbia University

st3107 commented 4 years ago

Thank you.

On Wed, Jul 29, 2020 at 8:31 PM Simon Billinge notifications@github.com wrote:

ok, done.

On Wed, Jul 29, 2020 at 8:19 PM Songsheng Tao notifications@github.com wrote:

Hi @sbillinge https://github.com/sbillinge Could you merge this PR? Also, could you grant me the maintainer rights of this repo? Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/280#issuecomment-665997254, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABAOWUKIQFB36WKWLTNTJP3R6C37NANCNFSM4O2ZFHCA

.

-- Professor Simon Billinge Columbia University

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdAn/pull/280#issuecomment-666001914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI27ND6M5SIU6KBV26VUSEDR6C5P5ANCNFSM4O2ZFHCA .

-- [image: photo] Songsheng Tao Ph. D. student, Columbia University

347-749-7947 Create your own WiseStamp email signature https://www.wisestamp.com/signature-in-email/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=5823337284239360

xpdAcq / xpdAn

BLD: add install the extra package script; BUG: make tests pass in latest environment #280

Codecov Report