search

xpdAcq / xpdSim

simulator objects for bluesky, ophyd
http://xpdacq.github.io/xpdSim/
Other
0 stars 5 forks source link

ENH: let xpdsim use the latest version of databroker and ophyd #60

Closed st3107 closed 4 years ago

st3107 commented 4 years ago

Hi @sbillinge @chiahaoliu . I update the xpdsim so that it can use the latests verions of databroker and ophyd. Please review myedits. I plan to clean the four issues we have now and make a release of v0.4.1.

This is important because xpdsim is a dependency of xpdan. Xpdan uses the latest databroker and ophyd but this one doesn't. I am worried about this inconsistency will cause errors after we installed it from nsls-ii-forge.

st3107 commented 4 years ago

sorry. I mean clean the PRs not issues.

st3107 commented 4 years ago

There are so many issues there.

sbillinge commented 4 years ago

Hi @st3107 do you need this version merged or are you still working on it, it is not so clear (if yes, please ask for a merge)?

I don't see any CI running. We have tests, but is there a reason CI is not running or not installed?

Either way I am happy to merge to move this forward, though the main job for this release cycle was to make things more robust (and well documented) so that this is less of a headache in the future.....so if this CI issue needs to be corrected I would love to do that these days too. Sorry that you have to do all this cleaning @st3107 ! It is also a good lesson why we need our code to be well set up and tested in general (and use just the right number of dependencies as possible....not too few and not too many!)

st3107 commented 4 years ago

I need this PR merged. I fixed the syntax so that this software can run in the latest ophyd.

I am not sure about the CI. I don't have the access to the CI configuration so I cannot know why there is no CI on this PR.

This is a not part of the release cycle. But if we can have xpdsim running on latest ophyd and broker. The xpdan which depends on it will benefit from it.

sbillinge commented 4 years ago

Thanks @st3107