search

xpdAcq / xpdSim

simulator objects for bluesky, ophyd
http://xpdacq.github.io/xpdSim/
Other
0 stars 5 forks source link

Fix flake8 #62

Closed st3107 closed 4 years ago

st3107 commented 4 years ago

Hi @sbillinge Please merge this PR. I fix the flake8 line to long problem.

codecov-commenter commented 4 years ago

Codecov Report

Merging #62 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          228       250   +22     
=========================================
+ Hits           228       250   +22
Impacted Files Coverage Δ
xpdsim/__init__.py 100.00% <100.00%> (ø)
xpdsim/area_det.py 100.00% <100.00%> (ø)
xpdsim/movers.py 100.00% <100.00%> (ø)
xpdsim/tests/test_dets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c476452...b0f7555. Read the comment docs.

st3107 commented 4 years ago

Hi @sbillinge . Could you make me the maitainer of this repo. I would like to realse a v0.4.1 so that this xpdsim can work in the latest version of databroker and ophyd.

this is actually a part of the release cycle because we foudn that there are package version conflicts when the xpdacq is installed and I suspect that it is from the xpdsim.

sbillinge commented 4 years ago

ok np

On Thu, Jul 2, 2020 at 12:22 PM Songsheng Tao notifications@github.com wrote:

Hi @sbillinge https://github.com/sbillinge . Could you make me the maitainer of this repo. I would like to realse a v0.4.1 so that this xpdsim can work in the latest version of databroker and ophyd.

this is actually a part of the release cycle because we foudn that there are package version conflicts when the xpdacq is installed and I suspect that it is from the xpdsim.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdSim/pull/62#issuecomment-653103580, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUPYYAMCTGXOLGVIXPTRZSX33ANCNFSM4OPAIMAQ .

-- Professor Simon Billinge Columbia University

sbillinge commented 4 years ago

ok, should be done.

On Thu, Jul 2, 2020 at 12:44 PM Simon Billinge sb2896@columbia.edu wrote:

ok np

On Thu, Jul 2, 2020 at 12:22 PM Songsheng Tao notifications@github.com wrote:

Hi @sbillinge https://github.com/sbillinge . Could you make me the maitainer of this repo. I would like to realse a v0.4.1 so that this xpdsim can work in the latest version of databroker and ophyd.

this is actually a part of the release cycle because we foudn that there are package version conflicts when the xpdacq is installed and I suspect that it is from the xpdsim.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xpdAcq/xpdSim/pull/62#issuecomment-653103580, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUPYYAMCTGXOLGVIXPTRZSX33ANCNFSM4OPAIMAQ .

-- Professor Simon Billinge Columbia University

-- Professor Simon Billinge Columbia University