search

xpdota / event-trigger

Comprehensive FFXIV Overlays, Triggers, Dot Tracker, Log Analysis, and more in an easy-to-use tool
Other
106 stars 32 forks source link

Read ACT Log Folder from Config #264

Open Lusaca87 opened 1 year ago

Lusaca87 commented 1 year ago

Hello!

After playing around with triggevent, i found an issue!

under "advanced" in the section directories there ist a button with "open act log dir" but this is used for the default one. if a user (like me) change the directory in the settings you can read the correct folder from "%appdata%\Advanced Combat Tracker\Config\Advanced Combat Tracker.config.xml"

in this xml file exists a node Config\SettingsSerializer ->

maybe this helps to open find a way to open the correct folder :)

xpdota commented 1 year ago

Would it help if I just allowed that to be a setting you can customize? The log folder isn't really used for anything other than that button and to make the file picker default to the logs folder when you're importing a log.

Lusaca87 commented 1 year ago

Hello.

I'm not sure if it would help, plus it would be a potential risk if you allow a user to enter something, especially if it's system relevant information.... (My experience after a few years of developing some applications).

I've also been looking in the repository for where the button is to create a code snippet but haven't found it yet.

Lusaca87 commented 1 year ago

i was a little bit bored, maybe this is usefull for you: change the subfix from txt to java to test it.

The sourcecode is generated for java 1.8 but it should be also work with newer versions.

Main.txt