search

xpepermint / angular-ui-switch

On/off switch button for AngularJS. DEPRECATED!
278 stars 127 forks source link

create switch size option #26

Open EskoCruz opened 8 years ago

EskoCruz commented 8 years ago

Here is a solution for issue #25 by @tomerb15.
I created an attribute of "size" that have the options of "small" or "large".
By using: size="small" or size="large"
This will change the size of the switch.

image

iJungleboy commented 8 years ago

I like the idea, but wouldn't it be better to use a class - like "sm" or "lg" to create this behaviour? a bit more bootstrappy...

evdoks commented 8 years ago

Any progress on this PR? Would love to have it!

EskoCruz commented 8 years ago

@iJungleboy @evdoks - I am a little confused. Do you two just want a class of "sm" and "lg" or something more along the lines of "switchery-sm" and "switchery-lg"?
class="switchery-sm"
I may have this just about written out now, just need to verify before checking in this PR. :+1:

iJungleboy commented 8 years ago

My suggestion is just to add the class "sm" or "lg" - so you might have a class="green sm" and it would do both.

EskoCruz commented 8 years ago

@xpepermint This is ready to be reviewed and merged to the master branch.

iJungleboy commented 8 years ago

@EskoCruz that's awesome :+1: I hope @xpepermint will find time to go through the pulls soon :)

yagotome commented 7 years ago

I think it'd be better if you make that "size" attribute an integer so that I'm able to have many different sizes to choose instead of just 3 (small, medium or large).