xpepermint / vue-builder

Server-side and client-side rendering for Vue.js.
34 stars 2 forks source link

Koa2 support #1

Closed kristianmandrup closed 8 years ago

kristianmandrup commented 8 years ago

Hi there,

Really excited about your most recent work. I managed to create a Koa2 compatible version of your express-vue-builder here https://github.com/kristianmandrup/koa-vue-builder/

You are very welcome to mention it as an option on your Readme. Perhaps we could collaborate somehow... Cheers ;)

xpepermint commented 8 years ago

This is great! We are headed towards the same goal and cooperation is what makes us human :).

Would you be so kind and split your package into two separated packages as I did in the latest version? The reason for this is to include the development server only in development and the bundle renderer only in production.

Please let me know when you do this so I can update the readme files on all related packages.

kristianmandrup commented 8 years ago

Cool :) I'm now working on the dev server part.

https://github.com/kristianmandrup/koa-vue-dev

Had problems running npm i but it should (hopefully) work

kristianmandrup commented 8 years ago

BTW, looks like you forgot to remove the unused build dependency in https://github.com/xpepermint/express-vue-builder/blob/master/example/server/middlewares/vue.js

xpepermint commented 8 years ago

Fixed, thanks. Can you describe the npm i problem? Peer dependencies?

kristianmandrup commented 8 years ago

Just temporarily a slow connection for some reason.

npm ERR! registry error parsing json

My package.json is valid

xpepermint commented 8 years ago

Hum... I remember seeing this once in awhile. I'll take a look.

xpepermint commented 8 years ago

Looks ok - I believe it's the ~network issue.

xpepermint commented 8 years ago

Hey @kristianmandrup, what's the status of your koa forks?

kristianmandrup commented 8 years ago

They should be good. Try yourself ')

xpepermint commented 8 years ago

All related readme files have been updated.

kristianmandrup commented 8 years ago

Cool :)