search

xperia64 / android-mkxp

A port of MKXP and its dependencies to Android
18 stars 21 forks source link

Force 24-bit color + catch-up commits + proper kill #10

Closed pulsejet closed 7 years ago

pulsejet commented 7 years ago

https://github.com/xperia64/android-mkxp/commit/ae3202300ebd5b7623a93249eca2b5208366310f : Force use 24-bit color depth for all devices. Some devices were using 16 or 8-bit colors, leading to weird visuals. 32-bit doesn't work, so 24 should be enough. Tested known affected GPUs (now corrected): Adreno 405 (Redmi 3S Prime) Adreno 505 (Moto G4 Plus) Adreno 510 (Redmi Note 3 Snapdragon 650) PowerVR G6200 (Xperia M5 Dual)

https://github.com/xperia64/android-mkxp/commit/e0acfca42e69283e644f473ae1d2c3fcdc3552a6 : Kill the app on exit so that the process doesn't continue running and prevent mkxp from starting properly when restarted

https://github.com/xperia64/android-mkxp/commit/adc53997107718e9782bdcde0308ba6aa7a08f19, https://github.com/xperia64/android-mkxp/commit/45ac75a3f6cb291453de373bda297c6df27e6409 : Did some suggested changes

https://github.com/xperia64/android-mkxp/commit/7465db90aeaaef81f72aa2aefd752a9e95d8b5ea : The latest commits (till https://github.com/Ancurio/mkxp/commit/55cec53911f6706f6ad7ae58095644235e2259ba) by @Ancurio in the main mkxp repository. Nothing very serious, but good to keep updated.

Ancurio commented 7 years ago

Apparently, since doing it only once above isn't working

Okay, that's definitely curious, I should tell the SDL folks about that. Once again, you tested that having the attributes set in either only the first location or only the second location does not work, correct?

Ancurio commented 7 years ago

I read somewhere that you are supposed to set attributes before the window is initialized, so put it it below. Not sure if necessary though.

But there was no window initialization, just a pointer assignment. A window can't be initialized twice anyway (it's created in the main thread and passed off to the RGSS thread). That's why I thought it was a cosmetic change on first glance.

pulsejet commented 7 years ago

@Ancurio, removed the SetAttribute at the top and it worked. Weird, definitely hadn't worked the last time I tried it o_O. I probably accidentally pushed a wrong binary or tried downgrading while testing... Also set depth size to 0.

xperia64 commented 7 years ago

This was closed automatically by my attempt to fully remove some of the old larger zip files from the repo. I'm going to want to prune boost_headers as well.