search

xperseguers / t3ext-extractor

TYPO3 Extension extractor
https://extensions.typo3.org/extension/extractor
GNU General Public License v2.0
14 stars 23 forks source link

Metadata in image results in Devision by zero error #57

Closed bmheins closed 1 year ago

bmheins commented 1 year ago

bug-extractor-image

The image above leads to a "Division by zero" exception when uploading to TYPO3. It's thrown in the extractor extensions due to its EXIF metadata; in it the value "0/0" is set for "GPSAltitude" (and in some other places, see image below). (The image is a "real life" example; we stumbled upon this error in a production context. I just changed the image, not the metadata.)

Your extension tries to translate this relation into an absolute value and therefore throws the error.

In https://exiv2.org/tags.html for "Image.LensInfo" the value "0/0" is set for "unknown". Though this is is not the case for "GPSAltitude", but the value itself seems me to be legit and should IMHO be handled.

In the image above there are several occurances of the value "0/0":

image

xperseguers commented 1 year ago

The problem with the division by 0 is supposed to be fixed since 38dde2d0. Could you please make sure you are testing with the development branch?

bmheins commented 1 year ago

I can confirm that https://github.com/xperseguers/t3ext-extractor/commit/38dde2d0beef71c5dbf63f691ec35025e218767c fixes the problem. Thanks!

sfroemkenjw commented 1 year ago

Hello @xperseguers

Thank you for fixing that issue in Dec. 2022. Do see a chance to release a new version?

Stefan

xperseguers commented 1 year ago

Done right now. Thanks for pinging :)